Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed naming for OTLP container ports from agent JSON #252

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

jefchien
Copy link
Contributor

Description of changes:
The agent JSON can have an OTLP configuration in the metrics/metrics_collected, logs/metrics_collected, and traces/traces_collected sections. The port discovery function didn't take into account multiple and would drop one as a duplicate. Updated the function to name these ports otlp-<protocol>-<port> (e.g. otlp-http-4317) to prevent naming collisions and ensure that the ports are available.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jefchien jefchien merged commit abcb8b7 into main Oct 16, 2024
8 checks passed
@jefchien jefchien deleted the fix-tests branch October 16, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants